Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stage env detection #407

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix stage env detection #407

merged 2 commits into from
Jun 2, 2021

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented May 18, 2021 •
edited
Loading

Description

While login was correctly going to IMS stage, getCliInfo was returning 'prod' even if AIO_CLI_ENV=stage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho requested review from shazron and Himavanth May 18, 2021 09:55
@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #407 (7a83efc) into master (d5e58be) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1690      1691    +1     
  Branches       285       284    -1     
=========================================
+ Hits          1690      1691    +1
Impacted Files Coverage Δ
src/lib/app-helper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e58be...7a83efc. Read the comment docs.

Himavanth
Himavanth approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@Himavanth Himavanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moritzraho moritzraho merged commit d15616a into adobe:master Jun 2, 2021
@moritzraho moritzraho deleted the fix-stage-env branch June 2, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himavanth Himavanth Himavanth approved these changes

@shazron shazron Awaiting requested review from shazron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moritzraho @Himavanth